Optimize NativeAOT delegate field layout#129304
Merged
Merged
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 11, 2026
Open
jkotas
approved these changes
Jun 12, 2026
jkotas
reviewed
Jun 12, 2026
jkotas
reviewed
Jun 12, 2026
jkotas
reviewed
Jun 12, 2026
jkotas
reviewed
Jun 12, 2026
jkotas
reviewed
Jun 12, 2026
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 12, 2026
Member
|
/ba-g armel build break that is fixed in main already, DeadLetter |
Contributor
Author
Member
|
Makes sense to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placing the 2 fields used to call a delegate makes it less likely to split cache lines and makes every delegate call on arm64 smaller due to it being able to use
ldp.Diffs are here for x64 and here for arm64.
I'm planning to do a similar change for CoreCLR after #99200.
cc @MichalStrehovsky this was the arm64 size reduction I mentioned on Discord.